Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added web.im.replies #339

Merged
merged 1 commit into from
May 16, 2017
Merged

added web.im.replies #339

merged 1 commit into from
May 16, 2017

Conversation

moinism
Copy link
Contributor

@moinism moinism commented Apr 28, 2017 •
edited

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

Adds im.replies to Web API

Related Issues

N/A

Test strategy

Already covered in tests.

@CLAassistant
Copy link

CLAassistant commented Apr 28, 2017 •
edited

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 28, 2017 •
edited

Codecov Report

Merging #339 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #339   +/-   ##
=======================================
  Coverage   85.72%   85.72%           
=======================================
  Files          44       44           
  Lines        1198     1198           
  Branches      176      176           
=======================================
  Hits         1027     1027           
  Misses        171      171

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 652e68b...c7b825d. Read the comment docs.

@aoberoi
Copy link
Contributor

aoberoi commented May 16, 2017

LGTM!

@aoberoi
Copy link
Contributor

aoberoi commented May 16, 2017

note: will need to regenerate the docs after this merge.

@aoberoi aoberoi merged commit 6f46169 into slackapi:master May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoberoi aoberoi aoberoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@moinism @CLAassistant @aoberoi